RFR: 8276743: Make openjdk build Zip Archive generation "reproducible"
Erik Joelsson
erikj at openjdk.java.net
Fri Nov 12 14:29:33 UTC 2021
On Fri, 12 Nov 2021 14:22:09 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> @erikj79 all tests pass, ready for re-review please, thanks
>
> @andrew-m-leonard Yes, pushing an empty commit is much better. The Skara tooling will automatically squash all commits in the PR when it is integrated, so it will be fully invisible in the end.
>
> But there is a way to trigger re-runs, although I realize is has close to zero visibility (I'll need to blame Github for that :-().
>
> Go to your personal fork of the JDK, select the "Actions" tab, select "Pre-submit tests" in the list to the left, and then press the `Run workflow` button in the cyan `This workflow has a workflow_dispatch event trigger.` field.
>
> There you can select branch to run, and also additionally modify the set of platforms run.
> @magicus is pushing an empty commit or dummy change preferable?
Yes, I think that's the only good way of re-triggering github actions. While working on a PR, it's better to let history be history so review comments don't get lost. When we finally integrate to mainline, everything will be squashed automatically.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6311
More information about the build-dev
mailing list