Integrated: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders

Jayathirth D V jdv at openjdk.java.net
Tue Nov 16 13:22:40 UTC 2021


On Thu, 11 Nov 2021 05:52:18 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set any deployment target when when we use xcrun to create .air file and this issue looks similar to https://developer.apple.com/forums/thread/105719. Also https://developer.apple.com/forums/thread/105719 states that even if they set app deployment target they need to explicitly set deployment in "xcrun metal".
> 
> Made same change to use -mmacosx-version-min=10.12.00 in our make file. Whether we should keep 10.12.00 or 10.13/14 is open to discussion for metal pipeline.
> 
> SwingSet2, J2DDemo & JCK/jtreg runs in CI are green. Also Vitaly(Submitter) has confirmed that patch resolves the issue.

This pull request has now been integrated.

Changeset: 9a9a157a
Author:    Jayathirth D V <jdv at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/9a9a157a7d45cbfb016d4427931e1d5345210f7a
Stats:     16 lines in 1 file changed: 15 ins; 0 del; 1 mod

8276905: Use appropriate macosx_version_minimum value while compiling metal shaders

Reviewed-by: ihse, kcr, erikj, prr

-------------

PR: https://git.openjdk.java.net/jdk/pull/6346



More information about the build-dev mailing list