Integrated: 8277089: Use system binutils to build hsdis
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Tue Nov 16 14:50:40 UTC 2021
On Sat, 13 Nov 2021 08:08:53 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
> hsdis requires binutils source tree for building. Most of Linux distros provide binutils package. (e.g. binutils-devel from Fedora, binutils-dev from Ubuntu)
> It would be nice to be able to use them like zlib and lcms.
>
> Unfortunately bfdver.h would not be provided because it is not included install files (`make install`) in binutils. So I changed to use `SEC_ELF_OCTETS` macro to detect binutils version because it was introduced at the same time as `bfd_octets_per_byte()`.
>
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;f=bfd/bfd-in2.h;h=618265039f697eab9e72bb58b95fc2d32925df58
>
> Please see [JDK-8244819](https://bugs.openjdk.java.net/browse/JDK-8244819) why we need version check.
This pull request has now been integrated.
Changeset: d5e47d6b
Author: Yasumasa Suenaga <ysuenaga at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/d5e47d6b84514edde23a8baff8c2274e5b3ca6bb
Stats: 61 lines in 3 files changed: 45 ins; 12 del; 4 mod
8277089: Use system binutils to build hsdis
Reviewed-by: ihse
-------------
PR: https://git.openjdk.java.net/jdk/pull/6378
More information about the build-dev
mailing list