RFR: 8277762: Allow configuration of HOTSPOT_BUILD_USER

Andrew Leonard aleonard at openjdk.java.net
Wed Nov 24 18:46:12 UTC 2021


On Wed, 24 Nov 2021 17:36:03 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> To better allow "reproducible builds", a new configure parameter is added to set the USERNAME build variable, rather than always using the current user:
>>     --with-build-user=<username> 
>> HOTSPOT_BUILD_USER is then set to a reproducible USERNAME if required.
>> 
>> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> make/autoconf/basic.m4 line 99:
> 
>> 97: 
>> 98:   # Setup username (for use in adhoc version strings etc)
>> 99:   AC_ARG_WITH([build-user], [AS_HELP_STRING([--with-build-user],
> 
> This variable is currently initiated in a rather weird location given what it's used for. As it used to be a one liner, it didn't seem worth the effort to move it to a more suitable location, but when expanding it with a --with flag I think we should also move this to jdk-version.m4, which is the only place where it's currently used. I think it makes sense to treat this as part of the version variables as that's what it's used for.

it's also used in make/hotspot/lib/CompileJvm.gmk, but agree moving to jdk-versions.m4 makes sense

-------------

PR: https://git.openjdk.java.net/jdk/pull/6542



More information about the build-dev mailing list