RFR: 8274851: [PPC64] Port zgc to linux on ppc64le [v2]

Niklas Radomski nradomski at openjdk.java.net
Fri Oct 8 15:41:51 UTC 2021


On Thu, 7 Oct 2021 13:54:16 GMT, Per Liden <pliden at openjdk.org> wrote:

>> Niklas Radomski has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update autoconf error message
>>  - Remove copyright headers
>
> src/hotspot/share/gc/z/zBarrierSetAssembler.cpp line 30:
> 
>> 28: 
>> 29: Address ZBarrierSetAssemblerBase::address_bad_mask_from_thread(Register thread) {
>> 30:   return Address(thread, (intptr_t) ZThreadLocalData::address_bad_mask_offset());
> 
> Instead of casting here in this platform agnostic code, I'd suggest that you add a new constructor for `Address` on PPC, one that takes `(Register, ByteSize)` arguments. Other platforms have that, so I'm a bit surprised that PPC doesn't already have that too.

Good catch, thank you for the suggestion! Totally agreed, I changed it accordingly.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5842



More information about the build-dev mailing list