RFR: 8275128: Build hsdis using normal build system [v3]

[Magnus Ihse Bursie]

On Tue, 12 Oct 2021 12:41:40 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Magnus Ihse Bursie has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Fixes after code review remarks
>
> make/Hsdis.gmk line 70:
> 
>> 68:   HSDIS_TOOLCHAIN_CFLAGS :=
>> 69:   HSDIS_TOOLCHAIN_LDFLAGS := -L/usr/lib/gcc/$(MINGW_BASE)/9.2.0  -L/usr/$(MINGW_BASE)/sys-root/mingw/lib
>> 70:   HSDIS_TOOLCHAIN_LIBS := /usr/$(MINGW_BASE)/sys-root/mingw/lib/dllcrt2.o -lmingw32 -lgcc -lgcc_eh -lmoldname -lmingwex -lmsvcrt -lpthread -ladvapi32 -lshell32 -luser32 -lkernel32
> 
> Maybe break up this line a bit?

Yes. I also extracted the dllcrt2.o file for added readability.

> make/autoconf/jdk-options.m4 line 803:
> 
>> 801:   if test "x$with_hsdis" = xyes; then
>> 802:     AC_MSG_ERROR([--with-hsdis must have a value])
>> 803:   elif test "x$with_hsdis" = xnone || test "x$with_hsdis" = x; then
> 
> Should we accept "no" as value too so we can use --without-hsdis?

Yeah, that's a good idea.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5908