RFR: JDK-8275406: Add copy-to-clipboard feature to snippet UI [v2]
Jonathan Gibbons
jjg at openjdk.java.net
Wed Oct 27 17:08:12 UTC 2021
On Fri, 22 Oct 2021 09:06:49 GMT, Pavel Rappo <prappo at openjdk.org> wrote:
>> I've traced the execution of a local jtreg run with a debugger and examined the respective `jtr` file. Here is what I saw. The locale that the javadoc under test uses is that of returned by java.util.Locale.getDefault(). This happens because neither of the three pieces -- jtreg, JavadocTester, or TestSnippetTag -- passes `-locale` to javadoc.
>>
>> Now I begin to wonder: how come we don't see failures on CI builds? Are we lucky and all the machines on which javadoc tests run use variants of English locale? Do we not have other tests where we hard-code English string variants? Is there something that I don't see?
>
> You don't have to do anything about locales in this PR; this part is fine as it is. I filed a bug, JDK-8275727, to address this issue at mass. It looks like almost half of javadoc tests have a similar issue.
I'm not very worried about the locale issue (JDK-8275727) since it is primarily just a problem that affects us ... i.e. it is at most a build/CI/test issue, not an end-user issue.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6011
More information about the build-dev
mailing list