RFR: 8274083: Update testing docs to mention tiered testing [v2]

David Holmes dholmes at openjdk.java.net
Thu Sep 23 05:49:56 UTC 2021


On Wed, 22 Sep 2021 12:28:18 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Now that OpenJDK has more or less complete `tier{1,2,3,4}` definitions, let's mention them in `testing.md`. 
>> 
>> Current patch is my braindump, I am open for suggestions :)
>
> Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert accidental edit
>  - More discussion

Hi Aleksey,

I don't have any significant misgivings about this version - thanks.

One correction needed below.

Thanks,
David

doc/testing.html line 73:

> 71: <h3 id="common-test-groups">Common Test Groups</h3>
> 72: <p>In the ideal world, contributors would be advised to run all the tests for every change. But in real world, one could only be expected to run as many tests as practical, while being mindful of the scope for the change, the testing resources available, etc.</p>
> 73: <p>The source tree currently defines a few common test groups in the relevant <code>TEST.groups</code> files. The test groups are either covering a specific component, for example <code>hotspot_gc</code>. It is a good idea to look into <code>TEST.groups</code> files to get a sense what tests are relevant to a particular JDK component.</p>

You state "The test groups are either ..." but there is no "or ..." in that sentence.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5615



More information about the build-dev mailing list