Integrated: 8273459: Update code segment alignment to 64 bytes

Scott Gibbons github.com+6704669+asgibbons at openjdk.java.net
Tue Sep 28 23:06:45 UTC 2021


On Thu, 16 Sep 2021 13:52:24 GMT, Scott Gibbons <github.com+6704669+asgibbons at openjdk.org> wrote:

> Change the default code entry alignment to 64 bytes from 32 bytes.  This allows for maintaining proper 64-byte alignment of data within a code segment, which is required by several AVX-512 instructions.
> 
> I ran into this while implementing Base64 encoding and decoding.  Code segments which were allocated with the address mod 32 == 0 but with the address mod 64 != 0 would cause the align() macro to misalign.  This is because the align macro aligns to the size of the code segment and not the offset of the PC.  So align(64) would align the PC to a multiple of 64 bytes from the start of the segment, and not to a pure 64-byte boundary as requested.  Changing the alignment of the segment to 64 bytes fixes the issue.
> 
> I have not seen any measurable difference in either performance or memory usage with the tests I have run.
> 
> See [this ](https://mail.openjdk.java.net/pipermail/hotspot-dev/2021-August/054180.html) article for the discussion thread.

This pull request has now been integrated.

Changeset: 53b25bce
Author:    Scott Gibbons <scott.gibbons at intel.com>
Committer: Sandhya Viswanathan <sviswanathan at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/53b25bce878bc291f3a217da7c26fd3097f18cfd
Stats:     27 lines in 4 files changed: 10 ins; 0 del; 17 mod

8273459: Update code segment alignment to 64 bytes

Reviewed-by: kvn, sviswanathan

-------------

PR: https://git.openjdk.java.net/jdk/pull/5547



More information about the build-dev mailing list