RFR: 8284507: GHA: Only check test results if testing was not skipped

Christoph Langer clanger at openjdk.java.net
Thu Apr 7 10:40:39 UTC 2022


On Thu, 7 Apr 2022 07:53:38 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> In GitHub Actions the step "Check that all tests executed successfully" will be marked as failing when the "Run tests" step did not run but some earlier step already failed. This is irritating and it can be corrected by doing the test check only if testing was not skipped.
> 
> Here is a link to such a test run where the check failed although the issue was with the cygwin installation: https://github.com/GoeLin/jdk11u-dev/runs/5788778433?check_suite_focus=true

> Thanks, this makes sense.
> 
> We cannot just do `continue-on-error: true` in checking step, like further test result packaging steps are doing, because we would lose the "error" status when tests _were_ executed. Checking for "skipped" status caters for that case.

Thanks for the review. GHA failure on Windows seems unrelated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8139



More information about the build-dev mailing list