RFR: 8284437: Building from different users/workspace is not always deterministic [v2]

Andrew Leonard aleonard at openjdk.java.net
Thu Apr 7 18:14:44 UTC 2022


On Thu, 7 Apr 2022 16:33:44 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> make/common/NativeCompilation.gmk line 1159:
>> 
>>> 1157:       ifeq ($(call isTargetOs, linux), true)
>>> 1158:         ifeq ($$($1_COMPILE_WITH_DEBUG_SYMBOLS), true)
>>> 1159:           $1_LINK_OBJS_RELATIVE := true
>> 
>> I realize this PR has already been integrated, but I have some questions about this. The comment talk about "ASM" objects (I assume that means output of assembly files), but the code change is not restricted to assembly files. 
>> 
>> Afaict, this change means that all builds on linux with debug symbols and reproducible builds will use relative paths! This is perhaps the most common compilation scenario, and it would mean that our efforts to keep a CWD neutral command line is basically in vain. :-(
>> 
>> Or can anyone (@erikj79, @andrew-m-leonard) explain to me why this would not be the case?
>
> You are correct for the linking command line. All the compilation command lines are still handled with flags instead.

What is CWD ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/8124



More information about the build-dev mailing list