RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v8]
Magnus Ihse Bursie
ihse at openjdk.java.net
Fri Apr 8 13:38:12 UTC 2022
On Fri, 8 Apr 2022 13:02:00 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 60 commits:
>>
>> - Merge branch 'master' into JDK-8242181
>> - Fix build, add GCC flag gdwarf-4 to exclude DWARF 5, add assertions
>> - Apply remaining review comments from Thomas Stuefe
>> - Change load_dwarf_file with DwarfFilePath and DebugInfo
>> - Revert renaming on Windows
>> - Merge branch 'master' into JDK-8242181
>> - Updating some comments
>> - Cleanup loading dwarf file and add summary
>> - Review comments of first pass by Thomas except dwarf file loading
>> - Merge branch 'master' into JDK-8242181
>> - ... and 50 more: https://git.openjdk.java.net/jdk/compare/60281810...229f1b90
>
> make/autoconf/flags-cflags.m4 line 116:
>
>> 114: fi
>> 115:
>> 116: CFLAGS_DEBUG_SYMBOLS="-g -gdwarf-4"
>
> We may need to guard this with a FLAGS_COMPILER_CHECK_ARGUMENTS. Perhaps it should also be applied only on Linux since the whole feature is Linux only. What do you think @magicus?
I'm googling around for some information about -gdwarf-4 but is mostly coming up empty handed. :( I found [this](https://www.phoronix.com/scan.php?page=news_item&px=GCC-11-DWARF-5-Possible-Default) saying that dwarf-5 became default in gcc11. It also claims dwarf-4 is about 10 years old. My guess is that all our supported gcc versions do support -gdwarf-4, but this needs to be verified.
In practice, we only use gcc on linux so I'm not convinced we need to have an addition check for that. If we ever are going to support gcc on other OSes I think we'll have many more, much harder problems, than to remove the -gdwarf-4 flag.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7126
More information about the build-dev
mailing list