RFR: 8284661: Reproducible assembly builds without relative linking

Andrew Leonard aleonard at openjdk.java.net
Mon Apr 11 14:09:45 UTC 2022


On Mon, 11 Apr 2022 12:55:16 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> This PR removes the need for relative object file linking introduced by JDK-8284437 for linux libraries, by specifying
>> .file <relative source path> directives in the linux .S source files. The source files specify a .file ASSEMBLY_SRC_FILE
>> where ASSEMBLY_SRC_FILE is defined by the NativeCompliation.gmk.
>> 
>> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> Maybe some short explanation should be added as comment in the src files?
> 
> If this makes the debuginfo files free from absolute paths on Linux, could you also adjust `open/test/jdk/build/AbsPathsInImage.java` to include those files on Linux? Would be good to be able to catch any regression to this behavior in the future.

thanks @erikj79
Not familiar with AbsPathsInImage, could you give some background please? wondering why it's not found these paths before, maybe it's not running on debugimages? What tier does it get run in?

@erikj79 this would be why: https://github.com/openjdk/jdk/blob/d442328bc2f2f4bc35dd054487a78552e3d9a759/test/jdk/build/AbsPathsInImage.java#L167

-------------

PR: https://git.openjdk.java.net/jdk/pull/8177



More information about the build-dev mailing list