RFR: 8284661: Reproducible assembly builds without relative linking [v3]

Magnus Ihse Bursie ihse at openjdk.java.net
Tue Apr 12 10:22:34 UTC 2022


On Mon, 11 Apr 2022 15:41:20 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

>> This PR removes the need for relative object file linking introduced by JDK-8284437 for linux libraries, by specifying
>> .file <relative source path> directives in the linux .S source files. The source files specify a .file ASSEMBLY_SRC_FILE
>> where ASSEMBLY_SRC_FILE is defined by the NativeCompliation.gmk.
>> 
>> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8284661: Reproducible assembly builds without relative linking
>   
>   Signed-off-by: Andrew Leonard <anleonar at redhat.com>

I agree with David. We need to update all files to use the same method for `.file`. I prefer to do it as part of this PR, so we can verify that all assembly files have correct data.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8177



More information about the build-dev mailing list