RFR: 8284661: Reproducible assembly builds without relative linking [v4]

Wed Apr 13 11:41:09 UTC 2022

On Wed, 13 Apr 2022 11:30:14 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

>> This PR removes the need for relative object file linking introduced by JDK-8284437 for linux libraries, by specifying
>> .file <relative source path> directives in the linux .S source files. The source files specify a .file ASSEMBLY_SRC_FILE
>> where ASSEMBLY_SRC_FILE is defined by the NativeCompliation.gmk.
>> 
>> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> Andrew Leonard has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8284661: Reproducible assembly builds without relative linking
>   
>   Signed-off-by: Andrew Leonard <anleonar at redhat.com>

The latest version looks much better! Fix the test to check for linux, and the indentation in the new header file, and I'd say you're good to go!

make/data/autoheaders/assemblyprefix.h line 24:

> 22: #
> 23: 
> 24:         // ASSEMBLY_SRC_FILE gets replaced by relative or absolute file path

While not critical, the indentation here looks surprising and odd.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8177