RFR: 8284539: Configure --with-source-date=version fails on MacOS
Erik Joelsson
erikj at openjdk.java.net
Fri Apr 15 12:38:37 UTC 2022
On Thu, 14 Apr 2022 16:13:59 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:
> JDK-8282769 added support for more ISO-8601 formats, but remove handling of just a date "YYYY-MM-DD" being present, which is the case for a configure using --with-source-date=version which uses the date string from version-numbers.conf.
> Also, the first date parse had an invalid format string "%FZ %TZ", with too many Zs.
> This PR corrects the first date parse to parse a standard ISO-8601 Zulu date&time: "%FT%TZ"
> Then it adds the final check for no time being specified.
>
> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
Marked as reviewed by erikj (Reviewer).
make/autoconf/util.m4 line 243:
> 241: # BSD date
> 242: # ISO-8601 date&time in Zulu 'date'T'time'Z
> 243: timestamp=$($DATE -u -j -f "%FT%TZ" "$2" "+%s" 2> /dev/null)
You are removing the space between FT and TZ, I'm just curious why and if that is significant.
EDIT: Never mind me, this looks good.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8247
More information about the build-dev
mailing list