RFR: 8284890: Support for Do not fragment IP socket options [v5]

[Michael McMahon]

On Tue, 19 Apr 2022 14:50:57 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix whitespace
>
> src/jdk.net/windows/native/libextnet/WindowsSocketOptions.c line 112:
> 
>> 110:             return optval;
>> 111:         }
>> 112:             handleError(env, rv, "get option IP_DONTFRAGMENT failed");
> 
> Is there some indentation issue here?

Yes, there is.

> test/jdk/jdk/net/ExtendedSocketOption/DontFragmentTest.java line 44:
> 
>> 42:         StandardProtocolFamily fam = args[0].equals("ipv4") ? INET : INET6;
>> 43:         System.out.println("Family = " + fam);
>> 44:         testDatagramChannel(args, fam);
> 
> Shouldn't there be a testcase for when DatagramChannel is opened using the no arg factory method `DatagramChannel.open()`?

I'm not sure there is value in testing all of these permutations. Distinguishing DatagramChannel and DatagramSocket probably made sense, but it's all the same implementation under the hood.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8245