RFR: 8285630: Fix a configure error in RISC-V cross build [v2]

Nick Gasson ngasson at openjdk.java.net
Thu Apr 28 08:16:43 UTC 2022


On Thu, 28 Apr 2022 07:27:36 GMT, Pengfei Li <pli at openjdk.org> wrote:

>> We are trying to cross build a RISC-V version of OpenJDK. We specified
>> `--openjdk-target=riscv64-linux-gnu` after `bash configure` but got an
>> error message.
>> 
>> 
>> configure: error: /usr/bin/bash /home/ent-user/jdk_src/make/autoconf/build-aux/config.sub riscv64-linux-gnu failed
>> configure exiting with result code 1
>> 
>> 
>> It shows the processing of `riscv64-linux-gnu` in script `config.sub`
>> fails. We see `config.sub` calls another script `autoconf-config.sub`
>> to validate and canonicalize a configuration type. The validation fails
>> here because `autoconf-config.sub` is a quite old version and has no
>> RISC-V support inside. Comments in those scripts tell us patching the
>> autoconf script is not a good idea so we add a fix in `config.sub` in
>> this patch.
>> 
>> We have verified RISC-V cross build succeeds after this change. As we
>> are not quite familiar with the build system, please let us know if this
>> is the best way to fix.
>
> Pengfei Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address comments

Is there a reason we can't import the latest upstream config.sub? That already handles RISC-V and AArch64 correctly.

https://git.savannah.gnu.org/cgit/config.git/plain/config.sub

-------------

PR: https://git.openjdk.java.net/jdk/pull/8420



More information about the build-dev mailing list