RFR: 8291454: Missing check for JLI C runtime library in CoreLibraries.gmk [v2]

Julian Waters jwaters at openjdk.org
Mon Aug 8 05:44:01 UTC 2022


> CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a defined, but empty macro in libjli if it is not defined in the build system, which is incorrect

Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'openjdk:master' into patch-1
 - Add missing check in JLI macro definitions

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9669/files
  - new: https://git.openjdk.org/jdk/pull/9669/files/4fb34244..b8c0ea89

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9669&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9669&range=00-01

  Stats: 10452 lines in 526 files changed: 6371 ins; 2832 del; 1249 mod
  Patch: https://git.openjdk.org/jdk/pull/9669.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9669/head:pull/9669

PR: https://git.openjdk.org/jdk/pull/9669



More information about the build-dev mailing list