RFR: 8290732: JNI DestroyJavaVM can start shutdown when one non-daemon thread remains [v3]
Thomas Stuefe
stuefe at openjdk.org
Thu Aug 11 07:50:28 UTC 2022
On Thu, 11 Aug 2022 02:13:00 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/jni/daemonDestroy/TestDaemonDestroy.java line 36:
>>
>>> 34: * @run main/native TestDaemonDestroy
>>> 35: * @run main/native TestDaemonDestroy daemon
>>> 36: */
>>
>> If you do two @test sections, you can give them speaking names(e.g. @test id=demon) and they can run in parallel.
>
> I didn't think that was warranted/necessary here.
I disagree. Splitting the test leads causes better runtime (on my 24 core machine: 10.5 seconds vs 16 seconds). It also makes the jtr file easier to read, since it only contains one test. It also is simpler to run a selected test if you want to reproduce an error.
It is regrettable that splitting the test section causes too much duplication. Maybe we could improve the jtreg syntax in the future.
-------------
PR: https://git.openjdk.org/jdk/pull/9803
More information about the build-dev
mailing list