RFR: 8290732: JNI DestroyJavaVM can start shutdown when one non-daemon thread remains [v3]

David Holmes dholmes at openjdk.org
Thu Aug 11 08:26:24 UTC 2022


On Tue, 9 Aug 2022 09:19:49 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed `if` block indentation per Magnus's request
>
> test/hotspot/jtreg/runtime/jni/daemonDestroy/TestDaemonDestroy.java line 72:
> 
>> 70:         oa.shouldHaveExitValue(0);
>> 71:         oa.shouldNotContain("Error: T1 isAlive");
>> 72:         oa.reportDiagnosticSummary();
> 
> Should we not add an `oa.shouldContain("T1 finished")` ?

I will add this too.

-------------

PR: https://git.openjdk.org/jdk/pull/9803



More information about the build-dev mailing list