RFR: 8290981: Enable CDS for zero builds [v2]

Thomas Stuefe stuefe at openjdk.org
Mon Aug 15 14:34:18 UTC 2022


On Mon, 15 Aug 2022 14:26:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>>> Why? `arguments.hpp` transitively includes it.
>> 
>> I thought the rule is not to rely on transitive includes. Unless it is an explicit umbrella header. If you need it, include it - that way if someone changes the include tree, we minimize the possibility of seemingly unrelated build errors.
>
> Ah, you mean because we use `RewriteBytecodes`, I see. Yes, we need the explicit header. My additional patch uses `UseSharedSpaces`, so it needs the additional include too.

Yes, RewriteBytecode. Sorry, should have said.

-------------

PR: https://git.openjdk.org/jdk/pull/9869



More information about the build-dev mailing list