RFR: 8292226: Prepare make for better Link Time Optimization support [v5]

Magnus Ihse Bursie ihse at openjdk.org
Mon Aug 22 09:56:27 UTC 2022


On Fri, 12 Aug 2022 16:45:21 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> The support for Link Time Optimization in the JDK's make system could do with some cleaning up, at the moment it simply assumes the compiler is gcc and sets the flags as such. Instead of introducing changes in bulk, as a first step, it would be good to simply supply the appropriate flags depending on the compiler and refine the flags for the one existing compiler with support for it. In practice the latter just means adding the proper -fuse-linker-plugin to gcc compile step when link-time-opt is specified, as without it the compiler generates both native code and information rich representation for Link Time Optimization. With this flag, native code generation is disabled and object files will contain only code required for Link Time Optimization, thus speeding up compile times as well.
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JVM_OPTIMIZATION is compiler agnostic

Whatever. Your patch makes the code less ugly, and possibly LTO a bit more useful. Let's save the "shall we remove this?" discussion for another day.

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9829



More information about the build-dev mailing list