RFR: 8292329: Enable CDS shared heap for zero builds [v2]

[Magnus Ihse Bursie]

On Tue, 23 Aug 2022 22:49:01 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> The suggested code should be something like this, note the double `$$` in the call.
>> 
>> Suggestion:
>> 
>>   $1_$2_CDS_DUMP_FLAGS := $$(CDS_DUMP_FLAGS)
>>   ifeq ($$(call check-jvm-feature, g1gc), true)
>>     $1_$2_CDS_DUMP_FLAGS += -XX:+UseG1GC
>>   endif
>
> I just realized that check-jvm-feature is only defined in HotspotCommon.gmk, which isn't included here (and can't really be either without modifications). Sorry to lead you on a wild goose chase. Unless Magnus can think of a reasonable way of exposing that macro here, I think your current solution is good enough.

Yes, it is good enough. That macro is supposed to work only in the context of the hotspot building.

-------------

PR: https://git.openjdk.org/jdk/pull/9984