Integrated: 8291444: GHA builds/tests won't run manually if disabled from automatic running

[Christoph Langer]

On Fri, 25 Nov 2022 13:24:09 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> This is an attempt to fix the issue reported in JDK-8291444.
> 
> The check for secrets.JDK_SUBMIT_FILTER should only be applied to the push event but not on e.g. workflow_dispatch.
> Currently setting JDK_SUBMIT_FILTER would lead to setting every platform to 'false', even when manually triggering the GHA run via workflow_dispatch.
> 
> I furthermore propose to relax the check for unknown events. In OpenJDK we only use/define workflow_dispatch and push. Other events would hence not trigger the workflow anyway. However, downstream vendors (like us in SapMachine) might use other events such as pull_request and they would then need to patch this away. This kind of downstream issue was also reported by [Amazon](https://mail.openjdk.org/pipermail/build-dev/2022-August/035102.html). If you agree, I would remove the commented lines 91-93. Otherwise I have to uncomment them.

This pull request has now been integrated.

Changeset: 5c0ff26f
Author:    Christoph Langer <clanger at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5c0ff26f321ad36daa34bfc5b2d013b6c4a03810
Stats:     14 lines in 1 file changed: 4 ins; 6 del; 4 mod

8291444: GHA builds/tests won't run manually if disabled from automatic running

Reviewed-by: serb, erikj, ihse

-------------

PR: https://git.openjdk.org/jdk/pull/11365