RFR: 8297963: Partially fix string expansion issues in the autoconf UTIL macros [v3]

[Julian Waters]

On Fri, 2 Dec 2022 13:20:23 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into patch-2
>>  - FLAGS_COMPILER_CHECK_ARGUMENTS should not quote ARG_ arguments
>>  - Remove special ARG_ handling in UTIL_DEFUN_NAMED
>>  - Wording
>>  - Partially fix string expansion issues in autoconf UTIL macros
>
> make/autoconf/util.m4 line 70:
> 
>> 68:     # Proceed at the risk of your own sanity, and don't say I didn't warn you when you inevitably suffer the same torment that I went through should you decide
>> 69:     # that you need to dive into it to fix anything
>> 70:     # ~Julian
> 
> 🤣 While I do appreciate humor and a bit of personal touch in comments (and I fully sympathize with your description!), this feels a bit over the top. Can you tone it down a bit and make it slightly more professional (it is okay to keep a bit of the sentimentality I think, to fully make the point on how difficult it is to modify).

Haha, sorry for letting the pent up bitterness overflow into the comments, I'll do just that. I've lost track of how much coffee and milk I've consumed while trying to get this to work...
Probably enough to shorten my lifespan by several decades at this point, if I'm being honest

-------------

PR: https://git.openjdk.org/jdk/pull/11458