RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v2]

[Magnus Ihse Bursie]

On Thu, 17 Nov 2022 04:44:18 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> make/autoconf/jdk-version.m4 line 84:
>> 
>>> 82:     DEFAULT: $USERNAME,
>>> 83:     DESC: [build username to use in version strings],
>>> 84:     IF_GIVEN: [
>> 
>> In general, I think these tests would be better expressed using the `CHECK_VALUE` construct, rather than `IF_GIVEN`. (A more specific reason is better than a vaguer and more general)
>
> Something concerning is happening when I do that: The code in the CHECK_VALUE block from the resulting configure script has all of the square brackets completely nuked, which is causing the logic in it to always fail. Switching back to IF_GIVEN on my end doesn't help either, it now always destroys all the brackets as well when it was working fine before. Something might be going wrong in the actual utility itself, but I can't tell what exactly :/

Is this still a problem after your DEFUN_NAMED fixes?

-------------

PR: https://git.openjdk.org/jdk/pull/11020