RFR: 8298175: JFR: Common timestamp for periodic events

David Holmes dholmes at openjdk.org
Wed Dec 7 05:25:11 UTC 2022


On Tue, 6 Dec 2022 15:31:22 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have review of infrastructure that makes it easier to write periodic events with the same timestamp.
> 
> Testing: jdk/jdk/jfr + tier1 + tier2
> 
> Thanks
> Erik

This seems okay. A couple of comments below.

Thanks.

src/jdk.jfr/share/classes/jdk/jfr/internal/RequestEngine.java line 211:

> 209:         long last = lastTimeMillis;
> 210:         // Bug 9000556 - current time millis has rather lame resolution
> 211:         // The use of os::elapsed_counter() is deliberate here, we don't

While you are here can you delete this comment block, or suitably modify it so that it makes sense for the code that follows. Thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/11541



More information about the build-dev mailing list