[jdk20] RFR: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation [v3]

[Erik Joelsson]

On Fri, 9 Dec 2022 15:15:55 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> @erikj79 I would like to use these make conditionals but somehow it doesn't work out. What am I doing wrong, any idea/hint?

Sorry, I have been away from makefiles for too long. What I suggested will not work inside a macro body. You will need to define the whole macro differently based on conditionals. Not as neat, but certainly more performant, and easier to debug when reading command lines from make.

Something like this (quick pseudo code):

ifeq (OS, msys)
  define link-file-relative
     ...
  endef
  define link-file-absolute
    ...
  endef
else
  define link-file-relative
  ...
endif

-------------

PR: https://git.openjdk.org/jdk20/pull/9