[jdk20] RFR: 8298527: Cygwin's uname -m returns different string than before [v4]

[Erik Joelsson]

On Tue, 13 Dec 2022 14:49:33 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> `uname -m` returns `.x86_64` after the latest upgread, instead of `x86_64`. Not sure why.
>> 
>> However, we can handle this in autoconf-config.guess, to unbreak the build.
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Undo changes to autoconf-config.guess

make/autoconf/build-aux/config.guess line 35:

> 33: OUT=`. $DIR/autoconf-config.guess 2> "$TMPFILE"`
> 34: ERR=`cat "$TMPFILE"`
> 35: rm "$TMPFILE"

I don't like relying on mktemp and the global temp directory in our build scripts. Unfortunately catching both stdout and stderr into variables isn't really possible in shell. However, running `autoconf-config.guess` should be fairly deterministic and quick, so I would suggest just ignoring stderr here:

Suggestion:

OUT=`. $DIR/autoconf-config.guess 2> /dev/null`

make/autoconf/build-aux/config.guess line 63:

> 61: 
> 62:   if [ "x$OUT" = x ]; then
> 63:     echo $ERR >&2

And just rerun the script if we need to print the error.
Suggestion:

    # Run autoconf-config.guess again to get the error message.
    . $DIR/autoconf-config.guess > /dev/null

-------------

PR: https://git.openjdk.org/jdk20/pull/15