RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v14]

Andrew Haley aph at openjdk.java.net
Tue Feb 1 18:38:21 UTC 2022


On Mon, 31 Jan 2022 22:25:38 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Alan Hayward has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix popframe failures
>
> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 417:
> 
>> 415:     // Enable PAC if this code has been built with branch-protection and the CPU/OS supports it.
>> 416: #ifdef __ARM_FEATURE_PAC_DEFAULT
>> 417:     if (_features & CPU_PACA) {
> 
> Style nit: no implicit booleans - expand as "if ( A & B != 0)"

Oh yuck, really? This is my punishment for not paying attention to the style guide dicussions.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6334



More information about the build-dev mailing list