RFR: 8203290: [AIX] Check functionality of JDK-8199712 (Flight Recorder) [v20]

[Thomas Stuefe]

On Mon, 14 Feb 2022 10:32:11 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Tyler Steele has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
>> 
>>  - Merge branch 'master' into JDK-8203290
>>  - Adds Oracle & IBM copyrights as per guidance from IBM legal team.
>>  - Removes incorrect Oracle copyright line from libperfstat_aix.cpp/hpp, and loadlib_aix.hpp
>>  - Edit thread_aix.cpp to match thread_linux.cpp in pd_get_top_fram_for_profiling and ...for_signal_handler
>>  - Addresses issues from review and other sm fixes
>>    
>>    - Adds commenting in regards to memory handling by SystemProcess &
>>    NetworkInterface classes
>>    - Replaces explicit initialization and copy of structs with memcpy
>>    and memset as appropriate
>>    - Renames internal struct definitions in os_perf_aix
>>    - Other minor fixes
>>  - Changes macoss -> macosx in problem list
>>  - Refactors loadlib_aix: Removes redundant c++ class
>>  - Merge branch 'master' into JDK-8203290
>>  - Implements JFR on AIX
>>    
>>    - Implements interfaces from os_perf.hpp in os_perf_aix.cpp
>>    - Updates libperfstat_aix to contain functionality needed by os_perf_aix
>>    - Implements missing functionality in loadlib_aix (Fixes failure noted
>>    by TestNativeLibraies.java)
>>    - Removes platform checks for --enable-feature-jfr (Now enable-able on
>>    all platforms)
>>    - Enables TestNetworkUtilizationEvent.java which now passes on AIX
>>    - Updates AIX JavaThread::pd_get_top_frame_for_profiling with changes from Linux
>
> make/autoconf/jvm-features.m4 line 3:
> 
>> 1: #
>> 2: # Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights reserved.
>> 3: # Copyright (c) 2022, IBM Corp.
> 
> I understand the discussion about copyright lines has plagued this PR, but this really looks odd: adding an IBM copyright line when just removing code. That does not make sense to me.

+1 Removing code does not add anything copyrightable; I'd remove that copyright line.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6885