RFR: 8188073: Add Capstone as backend for hsdis

Erik Joelsson erikj at openjdk.java.net
Thu Feb 17 14:19:06 UTC 2022


On Wed, 16 Feb 2022 21:55:36 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> The Capstone library is a simple to use, efficient disassembly library, distributed under the MIT license. 
> 
> This PR implements an hsdis backend using Capstone. It has been tested on Linux, macOS and Windows (x64).
> 
> The actual C implementation of the backend was done by @JornVernee. I assume there are plenty of room for enhancing this implementation, with options like in the binutils backend. Such improvements can be done later, by teams more familiar with the requirements of hsdis.

One style nit.

make/Hsdis.gmk line 157:

> 155: 
> 156: $(INSTALLED_HSDIS): $(BUILD_HSDIS_TARGET)
> 157: ifeq ($(HSDIS_BACKEND), binutils)

Don't we usually indent conditionals to the recipe level using spaces?

-------------

Marked as reviewed by erikj (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7506



More information about the build-dev mailing list