RFR: 8209784: Include hsdis in the JDK
Erik Joelsson
erikj at openjdk.java.net
Tue Feb 22 16:41:41 UTC 2022
On Tue, 22 Feb 2022 16:10:22 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting this, together with a valid backend using `--with-hsdis`, will bundle the generated hsdis library with the JDK.
>
> The PR also includes a refactoring of the hsdis handling in autoconf, breaking it out to a separate file `lib-hsdis.gmk`, and breaking the functionality up in separate functions per backend.
Marked as reviewed by erikj (Reviewer).
make/Hsdis.gmk line 186:
> 184: $(install-file)
> 185:
> 186: $(INSTALLED_HSDIS_IMAGE): $(BUILT_HSDIS_LIB)
This slipped past me earlier, but the install-hsdis target at the top level does not have any prereq. I believe it needs to depend on jdk-image for installation to the image to work. Otherwise it will just get deleted if the jdk-image target is built after.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7578
More information about the build-dev
mailing list