RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v16]

[Tyler Steele]

On Sat, 29 Jan 2022 06:09:17 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Tyler Steele has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Changes macoss -> macosx in problem list
>>  - Refactors loadlib_aix: Removes redundant c++ class
>
> src/hotspot/os/aix/loadlib_aix.cpp line 326:
> 
>> 324: // Helper for copying loaded module info to external callers.
>> 325: // To avoid dangling pointers 'next' is set to null
>> 326: static bool copy_lm_to_external(const loaded_module_t* const from, loaded_module_t* to) {
> 
> So, just to understand, the point of this function is to handle to==NULL (from is never NULL) and to set next to NULL? 
> 
> I'd probably keep doing this inline in the two places where this happens, but I leave it up to you. If you think this is cleaner, its fine too.

The purpose was actually to work through a compiler error that cropped up when I changed loaded_module_t. It ended up being simple to fix, but I left the plumbing in. I agree this is not worth keeping around. Thanks for pointing this out.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6885