Warning about git from 'make test' on Windows

[Langer, Christoph]

Hi Magnus,

thanks for opening the bug and I hope you'll get to fix it eventually. It's not urgent to me, though. I might add that I fixed the error message for me by installing the Cygwin package for Git. By doing that, it is correctly picked up and no issues with the path to it.

Best regards
Christoph

> -----Original Message-----
> From: Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com>
> Sent: Dienstag, 5. Juli 2022 12:44
> To: Langer, Christoph <christoph.langer at sap.com>; Andrey Turbanov
> <turbanoff at gmail.com>; build-dev at openjdk.java.net
> Subject: Re: Warning about git from 'make test' on Windows
> 
> Christoph, Andrey,
> 
> Thanks for your input and debugging. I have created
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.
> openjdk.org%2Fbrowse%2FJDK-
> 8289735&data=05%7C01%7Cchristoph.langer%40sap.com%7C1a67c2c65
> 92747f6e42908da5e73533f%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0
> %7C637926146654427371%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C
> %7C&sdata=BZUHbHjFTJlibZ0lVtKs85fqZ%2FJhMhTtBO6KRT0drvU%3D&
> amp;reserved=0 to track this. I believe this is easy to fix, but I'm not sure I'm
> able to provide a PR before I leave on vacation.
> 
> /Magnus
> 
> On 2022-06-03 09:09, Langer, Christoph wrote:
> > Hi,
> >
> > I see the same on my windows build. I verified that 8.3 filenames are
> enabled.
> >
> > I took a little closer look. In my PATH env in Cygwin I have:
> ...:/cygdrive/c/Program Files/Git/cmd:...
> >
> > The git path is resolved via UTIL_LOOKUP_PROGS(GIT, git) in
> basic_tools.m4. UTIL_LOOKUP_PROGS, defined in util_paths.m4 must
> somehow not be capable to correctly resolve the path with spaces. The
> output in configure is:
> >
> > checking for git...  Files/Git/cmd/git
> >
> > Maybe this gives a hint on how to fix it? I guess I can configure my path to
> use the 8.3 notation. But maybe UTIL_LOOKUP_PROGS could be improved?
> >
> > Cheers
> > Christoph
> >
> >> -----Original Message-----
> >> From: build-dev <build-dev-retn at openjdk.java.net> On Behalf Of
> Magnus
> >> Ihse Bursie
> >> Sent: Freitag, 3. Juni 2022 01:10
> >> To: Andrey Turbanov <turbanoff at gmail.com>; build-
> dev at openjdk.java.net
> >> Subject: Re: Warning about git from 'make test' on Windows
> >>
> >>
> >> On 2022-06-02 21:26, Andrey Turbanov wrote:
> >>> Hello.
> >>> I noticed strange warnings produced by 'make test' recently on my
> >>> Win11 installation. For example:
> >>>
> >>> $ make test TEST="tier1"
> >>> Building target 'test' in configuration 'windows-x86_64-server-release'
> >>> /usr/bin/bash: Files/Git/cmd/git: No such file or directory
> >>> /usr/bin/bash: Files/Git/cmd/git: No such file or directory Test
> >>> selection 'tier1', will run:
> >>>
> >>>
> >>> Also found this in
> >>> build\windows-x86_64-server-release\configure-support\config.log
> >>>
> >>> configure:29274: checking for git
> >>> configure:29502: result:  Files/Git/cmd/git
> >>>
> >>> Seems like space in git path is incorrectly handled.
> >>> Is it a known issue or is it a limitation of autoconf?
> >> Spaces in paths is always tricky and is best avoided. That being
> >> said, we try to make autoconf robust for tools in directories with space in
> them.
> >>
> >> Are you running in Cygwin?
> >>
> >> Can you verify that your C: drive can use short paths. See
> >> https://openjdk.java.net/groups/build/doc/building.html#spaces-in-pat
> >> h
> >>
> >> /Magnus
> >>> Andrey Turbanov