RFR: 8290059: Do not use std::thread in panama tests [v2]
Jorn Vernee
jvernee at openjdk.org
Fri Jul 22 16:45:59 UTC 2022
On Fri, 22 Jul 2022 14:56:16 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixes
>
> Looks good!
@mcimadamore Thanks for the comments. I've cleaned up the comments on the compiler switches (just removed them).
I also realized there was an unused typedef for `THREAD_ID`, which I've removed. Finally, I realized that after printing an error, we should probably also exit the test (I'd forgotten to add this before making the PR public). I've added a helper function called `fatal` that prints the error message and then calls `exit`. The tests still pass with that.
-------------
PR: https://git.openjdk.org/jdk/pull/9599
More information about the build-dev
mailing list