RFR: 8290373: Enable lossy conversion warnings on Windows [v4]

Jorn Vernee jvernee at openjdk.org
Tue Jul 26 13:21:08 UTC 2022


On Mon, 25 Jul 2022 01:15:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

> > I propose that when a patch touches a file with lossy conversion warnings disabled, it should also enable the warnings and fix them for that file.
> 
> This contradicts other common recomendations of not mixing unrelated issues in the same PR. Fixing style nits is harmless but fixing an actual lossy conversion issue could itself lead to bugs and unexpected fanout.

That's a good point. I think that takes piggybacking on other patches off the table then.

-------------

PR: https://git.openjdk.org/jdk/pull/9516



More information about the build-dev mailing list