RFR: 8290059: Do not use std::thread in panama tests [v2]

David Holmes dholmes at openjdk.org
Wed Jul 27 06:47:02 UTC 2022


On Tue, 26 Jul 2022 13:10:00 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

> Does run_in_new_thread seem good enough?

No, sorry, the fact it  both runs and joins is a critical aspect. `run_async` in `CompleteableFuture` just does the "run in new thread" part, whereas the `get()` on the returned `FutureTask` provides the "join". So a function that does both needs to make that clear in the name - and there is no nice succinct name for that, so we get stuck with something like `run_in_new_thread_and_join`. Or we just have ` startThread` and `joinThread` :)

-------------

PR: https://git.openjdk.org/jdk/pull/9599



More information about the build-dev mailing list