RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v3]
Leo Korinth
lkorinth at openjdk.java.net
Tue Jun 7 13:50:14 UTC 2022
On Mon, 6 Jun 2022 07:55:09 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>>
>> wip
>
> make/RunTests.gmk line 444:
>
>> 442: $(strip $(foreach parser,ParseCustomTestSelection ParseGtestTestSelection ParseMicroTestSelection ParseJtregTestSelection ParseSpecialTestSelection \
>> 443: ,$(call $(parser),$1)))
>> 444: endef
>
> As this is logically a one-liner macro, please format according to guidelines. Also try to keep lines shortish. Something like this:
>
> Suggestion:
>
> ParseTestSelection = \
> $(strip $(foreach parser, ParseCustomTestSelection ParseGtestTestSelection ParseMicroTestSelection \
> ParseJtregTestSelection ParseSpecialTestSelection, \
> $(call $(parser), $1) \
> ))
I made it a one-liner, and I refactored the code to use `or`
-------------
PR: https://git.openjdk.java.net/jdk/pull/9028
More information about the build-dev
mailing list