RFR: 8287828: Fix so that one can select jtreg test case by ID from make [v4]

[Ioi Lam]

On Tue, 7 Jun 2022 17:39:14 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> One can select a testcase by ID when running a jtreg test case directly from jtreg (using the testcase.java#testID syntax). However, this has not been possible to do when launching jtreg indirectly from make.
>> 
>> This fix attempts to address this issue. I have not tested this thoroughly yet, I wanted to show the code to get feedback first. The idea is to *not* emulated destructive imperative assignments through the use of eval. I instead try to handle it in a functional style without reassigning variables. I have tried to make the change as small as possible.
>> 
>> I am not used to change the build system, so I would appreciate thorough review.
>> 
>> `IfAppend` and `IfPrepend` are general purpose functions. If similar functions exists elsewhere inside the code base or in make itself I should probably use those instead. If they do not exist, they might be useful elsewhere and maybe should be placed in a common make file instead of the RunTests.gmk file.
>
> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
> 
>   wip

Marked as reviewed by iklam (Reviewer).

make/RunTests.gmk line 357:

> 355:     $(subst .java,,$(subst .java,,$(suffix $(notdir $1))))
> 356: 
> 357: # The test selector starting with a hash (#testid) will be stripped by all

Small nit - I think "selection" and "test selector" in the comments should be changed to "test id" so you don't call the same thing with 3 different names. But otherwise the change looks good to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/9028