RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4]

Aleksey Shipilev shade at openjdk.java.net
Fri Jun 10 07:33:12 UTC 2022


On Fri, 10 Jun 2022 07:13:32 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apparently that was not a legal reference to actions/checkout. Try another way.
>
> .github/workflows/build-cross-compile.yml line 89:
> 
>> 87:           sudo apt-get install gcc-${{ inputs.apt-gcc-version }} g++-${{ inputs.apt-gcc-version }} libxrandr-dev${{ inputs.apt-architecture }} libxtst-dev${{ inputs.apt-architecture }} libcups2-dev${{ inputs.apt-architecture }} libasound2-dev${{ inputs.apt-architecture }}
>> 88:           sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 100 --slave /usr/bin/g++ g++ /usr/bin/g++-10
>> 89:           sudo apt-get install gcc-10-${{ matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-abi}}=10.3.0-1ubuntu1~20.04cross1 g++-10-${{ matrix.gnu-arch }}-linux-gnu${{ matrix.gnu-abi}}=10.3.0-1ubuntu1~20.04cross1
> 
> Should `10.3.0-1ubuntu1~20.04cross1` also go into common "var", like `apt-gcc-version` did?

Also, I think we can speed up this part by merging two `apt-get install` invocation lines together. It was separate before, because it was two steps, unnecessary now.

-------------

PR: https://git.openjdk.org/jdk/pull/9063



More information about the build-dev mailing list