RFR: 8287906: Rewrite of GitHub Actions (GHA) sanity tests [v4]

Magnus Ihse Bursie ihse at openjdk.java.net
Fri Jun 10 09:39:04 UTC 2022


On Fri, 10 Jun 2022 07:07:11 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apparently that was not a legal reference to actions/checkout. Try another way.
>
> .github/actions/get-bundles/action.yml line 103:
> 
>> 101:           jdk_dir="$(cygpath $jdk_dir)"
>> 102:           symbols_dir="$(cygpath $symbols_dir)"
>> 103:           tests_dir="$(cygpath $tests_dir)"
> 
> Here, and maybe later: how safe it is to use Cygwin utilities like `cygpath` in MSYS2 context?

Perfectly safe and officially supported. MSYS2 is related to MSYS(1) by name only, it is in reality a fork/clone of Cygwin. The principal difference is that MSYS2 is more pragmatic when it comes to choosing between perfect POSIX compliance, or have tooling that is helpful in creating a POSIX-like build environment on Windows.

-------------

PR: https://git.openjdk.org/jdk/pull/9063



More information about the build-dev mailing list