assembler_x86.cpp:11128:38: error: 'this' pointer is null

[Aleksey Shipilev]

On 6/16/22 20:00, Browser wrote:
> ... It did result in a runable `./build/linux-x86_64-server-release/images/jdk/bin/java` / JDK, 
> however I no longer have confidence in the JDK generated. null pointers make me nervous, 
> use-after-free warnings also make me nervous! Is this something I need to worry about? Or is the
> JDK still good?
Depends on your current worldview, to be honest.

Optimistic view: OpenJDK builds already disable a whole lot of compiler warnings. Newer toolchains 
routinely come with new warnings that are either fixed in code, or added to global ignore lists, or 
disabled per code spot. The OpenJDK build faces this more often because it builds with 
warnings-as-errors by default. As long as your built OpenJDK passes testing, it is probably fine.

Pessimistic view: compiler warnings are real, the bugs they signify are real, the products that 
build with warnings are probably subtly broken, no reasonable amount of testing would cover 
everything, things fall apart, centre cannot hold, mere anarchy is loosed upon the world, he comes 
he comes his unholy radiance destroying all enlightenment all is lost all is lost...

I believe many people normally oscillate between these two.

We should strive to get the cleanest builds by default, of course, by examining each warning and 
ballparking its risks. Your case only highlights that is the ongoing struggle.

-- 
Thanks,
-Aleksey