RFR: JDK-8282700: Properly handle several --without options during configure [v2]
Julian Waters
jwaters at openjdk.java.net
Mon Mar 7 08:07:30 UTC 2022
> Some of the --without options are not properly handled and will crash when processed (For example, --without-version-string), in other cases the --without-* option will actually silently produce incorrect results instead of actually doing what --without-* implies (For example, --without-build-user and all the --with-vendor-* options). The most elegant way to solve this would simply be to handle such cases and display warnings when they're encountered (or if the option is critical to the build process, throwing an error)
>
> Even if it doesn't make sense to pass said option however, it should display a warning instead of letting configure exit with a confusing error when it's run
>
> This is an initial change and I may have missed several options; I'll double check and make sure in the meantime
Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
Handle remaining options and change critical options to error when --without is passed
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7713/files
- new: https://git.openjdk.java.net/jdk/pull/7713/files/54bbfae5..c9699eb7
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7713&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7713&range=00-01
Stats: 24 lines in 1 file changed: 12 ins; 10 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/7713.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7713/head:pull/7713
PR: https://git.openjdk.java.net/jdk/pull/7713
More information about the build-dev
mailing list