RFR: JDK-8282700: Properly handle several --without options during configure [v2]
David Holmes
dholmes at openjdk.java.net
Tue Mar 8 04:19:08 UTC 2022
On Mon, 7 Mar 2022 08:07:30 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> Some of the --without options are not properly handled and will crash when processed (For example, --without-version-string), in other cases the --without-* option will actually silently produce incorrect results instead of actually doing what --without-* implies (For example, --without-build-user and all the --with-vendor-* options). The most elegant way to solve this would simply be to handle such cases and display warnings when they're encountered (or if the option is critical to the build process, throwing an error)
>>
>> Even if it doesn't make sense to pass said option however, it should display a warning instead of letting configure exit with a confusing error when it's run
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>
> Handle remaining options and change critical options to error when --without is passed
I've never felt that configure's `--without-x` options really make any sense for the bulk of our `--with-x` options that define "properties". We have a bunch of properties that have to be set and the default is in a configuration file. You can then use `--with-x=foo` to override that. If you pass "" as the value then you get what you deserve if the build fails. Passing --without-x makes no sense at all IMHO.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7713
More information about the build-dev
mailing list