RFR: JDK-8282700: Properly handle several --without options during configure [v4]
Magnus Ihse Bursie
ihse at openjdk.java.net
Thu Mar 10 12:00:54 UTC 2022
On Thu, 10 Mar 2022 11:49:14 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> Ok, now I've tried to dig through Apple's somewhat confusing documentation on CFBundleVersion and CFBundleShortVersionString. My takeaway is that we should either publish the build number there, or 0 if we have no build number.
>>
>> This is basically what is done by the code, and that was *exactly* what was done by the code, prior to the fix were we allowed an empty build number (JDK-8274980). So this code should also have been updated then. I've opened JDK-8282948 to fix this.
>>
>> But still the effect for this PR is that a valueless --with-macosx-bundle-build-version is not accepted.
>
> Got it, should I link JDK-8282948 into this PR while addressing this issue in the meantime?
> (On a side note the macOS tier 1 tests are also failing after this change, so you may be right that the build will inevitably fail when this has no value)
JDK-8282948 will go in before this. But you can fix your code in the meantime to do the same yes/no check.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7713
More information about the build-dev
mailing list