RFR: JDK-8282700: Properly handle several --without options during configure [v5]

Julian Waters jwaters at openjdk.java.net
Thu Mar 10 14:32:31 UTC 2022


> Some of the --without options are not properly handled and will crash when processed (For example, --without-version-string), in other cases the --without-* option will actually silently produce incorrect results instead of actually doing what --without-* implies (For example, --without-build-user and all the --with-vendor-* options). The most elegant way to solve this would simply be to handle such cases and display warnings when they're encountered (or if the option is critical to the build process, throwing an error)
> 
> Even if it doesn't make sense to pass said option however, it should display a warning instead of letting configure exit with a confusing error when it's run

Julian Waters has updated the pull request incrementally with one additional commit since the last revision:

  MACOSX_BUNDLE_BUILD_VERSION cannot be empty

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7713/files
  - new: https://git.openjdk.java.net/jdk/pull/7713/files/52dd398e..4eb5c85a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7713&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7713&range=03-04

  Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7713.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7713/head:pull/7713

PR: https://git.openjdk.java.net/jdk/pull/7713



More information about the build-dev mailing list