RFR: JDK-8282700: Properly handle several --without options during configure [v6]

Julian Waters jwaters at openjdk.java.net
Fri Mar 11 05:00:24 UTC 2022


> Some of the --without options are not properly handled and will crash when processed (For example, --without-version-string), in other cases the --without-* option will actually silently produce incorrect results instead of actually doing what --without-* implies (For example, --without-build-user and all the --with-vendor-* options). The most elegant way to solve this would simply be to handle such cases and display warnings when they're encountered (or if the option is critical to the build process, throwing an error)
> 
> Even if it doesn't make sense to pass said option however, it should display a warning instead of letting configure exit with a confusing error when it's run

Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into without
 - MACOSX_BUNDLE_BUILD_VERSION cannot be empty
 - Fix syntax errors
 - Fold --without checks into more compact code
 - Handle remaining options and change critical options to error when --without is passed
 - Initial proper handling of some --without arguments

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7713/files
  - new: https://git.openjdk.java.net/jdk/pull/7713/files/4eb5c85a..4cecda2b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7713&range=05
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7713&range=04-05

  Stats: 6806 lines in 298 files changed: 4386 ins; 662 del; 1758 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7713.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7713/head:pull/7713

PR: https://git.openjdk.java.net/jdk/pull/7713



More information about the build-dev mailing list