RFR: 8253495: CDS generates non-deterministic output [v6]

Ioi Lam iklam at openjdk.java.net
Tue Mar 15 08:18:56 UTC 2022


On Mon, 14 Mar 2022 22:07:24 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added helper function CollectedHeap::zap_filler_array_with
>
> test/hotspot/jtreg/runtime/cds/appcds/javaldr/LockDuringDumpAgent.java line 65:
> 
>> 63:                     if (elapsed >= timeout) {
>> 64:                         System.out.println("This JVM may decide to not launch any Java threads during -Xshare:dump.");
>> 65:                         System.out.println("This is OK because no string objects be in a locked state during heap dump.");
> 
> Should `no string objects be` be `no string objects could be`?

Thanks for the review. I've fixed the comment as you suggested.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7748



More information about the build-dev mailing list